Update system font stack to system-ui for testing #408
+6
−540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We previously had Cantarell and and Ubuntu in there and the Linux folks weren't happy. Ubuntu is an odd font for entire body copy and while folks seem to accommodate it for Linux's UI, on our site it wasn't well received. Same with Cantarell I think? I can't recall exactly why that one was removed. I'm also unsure about Oxygen. |
Remove primer-page-headers package
Remove primer-page-sections
Remove primer-tables package
a7a0780 to
7860079
Compare
|
Closing because this is super stale and we haven't quite figured out the right stack yet. Let's continue the discussion in #838. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chrome team are planning to deprecate
BlinkMacSystemFontin favor ofsystem-ui. This causes us a problem with supporting Linux while ensuring MacOS Chrome still gets system fonts. Some people browse the web in English but use their operating system in another language, fonts for a languages such as Chinese, Korean, or Japanese will not render well for a latin-based languages like English. Therefore usingsystem-uihigh in the font stack would cause problems for these users. Here's some example feedback from when we updated tosystem-uiprevious and quickly rolled back!:After a some research, the following stack is what I think might work and would like to test:
-apple-system, "Segoe UI", Oxygen-Sans, Ubuntu, Cantarell, system-ui, Roboto, Helvetica, Arial, sans-serif;Here's why each font is in that order:
-apple-systemfor Safari (iOS & macOS) and Firefox macOSSegoe UIfor WindowsOxygen-Sansfor KDEUbuntufor UbuntuCantarellfor GNOMEsystem-uifor Chrome macOS (has to come after linux fonts so as not to override)Robotofor Android and Chrome OS (after system-ui so as not to override Chrome on macOS)Helveticafor versions of macOS prior to 10.11 (unsure why we didn't go with Helvetica Neue)Arial- unsure if we had this here just for linux and is now unnecessary?I don't like how heavy handed this feels, and am worried that this stack won't cover all use cases. However I'm hoping it will cover "enough". Open to better (ideally simpler) suggestions!
cc @mdo @primer/design-systems